hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17877) Replace/improve HBase's byte[] comparator
Date Wed, 05 Apr 2017 16:37:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957181#comment-15957181
] 

Lars Hofhansl commented on HBASE-17877:
---------------------------------------

We could also flat-out use the Hadoop comparator - or for that matter even the plain Guava
comparator.
I do think, though, since this is do core to HBase that code should be part of HBase and be
changed by us, and not by a project we depend on.

Lemme make a new patch bringing back the change [~Apache9] points out - I wonder whether that
perhaps is the part that makes it slower in the one case that [~vik.karma] found; and also
leave the variables as final. The goal with this was to simply pull the Hadoop code into HBase
(and remove the extra Guava dependency).


> Replace/improve HBase's byte[] comparator
> -----------------------------------------
>
>                 Key: HBASE-17877
>                 URL: https://issues.apache.org/jira/browse/HBASE-17877
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Vikas Vishwakarma
>         Attachments: 17877-1.2.patch, ByteComparatorJiraHBASE-17877.pdf
>
>
> [~vik.karma] did some extensive tests and found that Hadoop's version is faster - dramatically
faster in some cases.
> Patch forthcoming.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message