hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17872) The MSLABImpl generates the invaild cells when unsafe is not availble
Date Sat, 08 Apr 2017 15:07:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15961858#comment-15961858
] 

stack commented on HBASE-17872:
-------------------------------

That is a very nice improvement [~chia7712]. +1.

It is a pain doing all the reflection code but thank you for taking the pain to do this at
test time -- and for moving all test baggage to test-time classes -- so runtime has no friction.

I was worried that what was there previous would not always do the right thing.

> The MSLABImpl generates the invaild cells when unsafe is not availble
> ---------------------------------------------------------------------
>
>                 Key: HBASE-17872
>                 URL: https://issues.apache.org/jira/browse/HBASE-17872
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17872.v0.patch, HBASE-17872.v1.patch, HBASE-17872.v2.patch,
HBASE-17872.v3.patch, HBASE-17872.v4.patch
>
>
> We will get the wrong position of buffer in multithreaded environment, so the method
makes the invalid cell in MSLAB.
> {noformat}
>   public static int copyFromBufferToBuffer(ByteBuffer in, ByteBuffer out, int sourceOffset,
>       int destinationOffset, int length) {
>     if (in.hasArray() && out.hasArray()) {
>       // ...
>     } else if (UNSAFE_AVAIL) {
>       // ...
>     } else {
>       int outOldPos = out.position();
>       out.position(destinationOffset);
>       ByteBuffer inDup = in.duplicate();
>       inDup.position(sourceOffset).limit(sourceOffset + length);
>       out.put(inDup);
>       out.position(outOldPos);
>     }
>     return destinationOffset + length;
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message