hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17800) [C++] handle exceptions in client RPC
Date Wed, 05 Apr 2017 13:13:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956828#comment-15956828
] 

Enis Soztutar commented on HBASE-17800:
---------------------------------------

Thanks [~xiaobingo] for the patch.
Can we get rid of the object creation here: 
{code} 
+      auto e = std::make_shared<std::exception>(error);
+      auto r = dynamic_pointer_cast<RemoteException>(e);
+      result &= r->do_not_retry();
{code}
maybe use dynamic_cast instead of dynamic_pointer_cast? 
Did you test the patch to see whether it works? 


> [C++] handle exceptions in client RPC
> -------------------------------------
>
>                 Key: HBASE-17800
>                 URL: https://issues.apache.org/jira/browse/HBASE-17800
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-17800-HBASE-14850.000.patch, HBASE-17800-HBASE-14850.001.patch,
HBASE-17800-HBASE-14850.002.patch
>
>
> Exceptions are ignored in current client RPC. They should be handled properly to be consumed
by RPC retry or propagated up to APIs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message