hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16875) Cleanup docs' use of try-with-resources
Date Thu, 13 Apr 2017 14:32:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967650#comment-15967650
] 

Hadoop QA commented on HBASE-16875:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 10s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 25s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 7s {color} | {color:green}
master passed {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 6s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 24s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 28m 39s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5
2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 3s {color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 120m 54s {color} | {color:red}
root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 21s {color}
| {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 163m 42s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.snapshot.TestExportSnapshot |
|   | hadoop.hbase.snapshot.TestMobExportSnapshot |
|   | hadoop.hbase.snapshot.TestSecureExportSnapshot |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12863256/HBASE-16875.master.002.patch
|
| JIRA Issue | HBASE-16875 |
| Optional Tests |  asflicense  javac  javadoc  unit  |
| uname | Linux 06ed7c9740d2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016
x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / da5fb27 |
| Default Java | 1.8.0_121 |
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/6416/artifact/patchprocess/patch-unit-root.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/6416/artifact/patchprocess/patch-unit-root.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/6416/testReport/ |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6416/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Cleanup docs' use of try-with-resources
> ---------------------------------------
>
>                 Key: HBASE-16875
>                 URL: https://issues.apache.org/jira/browse/HBASE-16875
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: Dima Spivak
>            Assignee: Jan Hentschel
>            Priority: Trivial
>              Labels: beginner
>         Attachments: HBASE-16875.master.001.patch, HBASE-16875.master.002.patch
>
>
> In a [number|https://github.com/apache/hbase/blame/bb3d9ccd489fb64e3cb2020583935a393382a678/src/main/asciidoc/_chapters/security.adoc#L205-L206]
[of|https://github.com/apache/hbase/blame/bb3d9ccd489fb64e3cb2020583935a393382a678/src/main/asciidoc/_chapters/security.adoc#L1019-L1020]
[places|https://github.com/apache/hbase/blame/bb3d9ccd489fb64e3cb2020583935a393382a678/src/main/asciidoc/_chapters/architecture.adoc#L222-L223],
we show examples that lend themselves to using Java 7's try-with-resources statement, but
we use the statement in a less-than-ideal nested way. Let's change our docs throughout to
do it [the recommended way|https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html].



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message