hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15199) Move jruby jar so only on hbase-shell module classpath; currently globally available
Date Wed, 26 Apr 2017 16:19:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985078#comment-15985078
] 

Sean Busbey commented on HBASE-15199:
-------------------------------------

in addition to the shell, I think we also need to add this when someone is expressly calling
one of our jruby based tools.

e.g. `bin/shutdown_regionserver.rb` says that it should be called like:
{code}
# This script is used to issue a stop command to a regionserver via RPC.
# Intended for use in environments where sshing around is inappropriate
# Run it like this by passing it to a jruby interpreter:
#
#  ./bin/hbase org.jruby.Main bin/shutdown_regionserver.rb c2021:16020
{code}

I haven't looked at all of our `bin/*.rb` examples, but I suspect we can solve this with a
check for `org.jruby.Main`

> Move jruby jar so only on hbase-shell module classpath; currently globally available
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15199
>                 URL: https://issues.apache.org/jira/browse/HBASE-15199
>             Project: HBase
>          Issue Type: Task
>          Components: dependencies, jruby, shell
>            Reporter: stack
>            Assignee: Xiang Li
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 15199.txt, HBASE-15199.master.001.patch
>
>
> A suggestion that came up out of internal issue (filed by Mr Jan Van Besien) was to move
the scope of the jruby include down so it is only a dependency for the hbase-shell. jruby
jar brings in a bunch of dependencies (joda time for example) which can clash with the includes
of others. Our Sean suggests that could be good to shut down exploit possibilities if jruby
was not globally available. Only downside I can think is that it may no longer be available
to our bin/*rb scripts if we move the jar but perhaps these can be changed so they can find
the ruby jar in new location.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message