hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15199) Move jruby jar so only on hbase-shell module classpath; currently globally available
Date Wed, 19 Apr 2017 15:25:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974905#comment-15974905
] 

Sean Busbey commented on HBASE-15199:
-------------------------------------

this looks like the wrong approach. the bit removed from the top level pom is just a {{dependencyManagement}}
entry; it says what version of jruby-complete ought to be used if anyone uses it. Only the
hbase-shell module actually uses it both before and after.

Likely what we need to fix this is a packaging change in when we include jruby-complete on
the classpath at runtime. We need it for the shell, but that should be it. AFAICT, the current
patch will still place it in the runtime classpath for all of our server processes.

> Move jruby jar so only on hbase-shell module classpath; currently globally available
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15199
>                 URL: https://issues.apache.org/jira/browse/HBASE-15199
>             Project: HBase
>          Issue Type: Task
>          Components: dependencies, jruby, shell
>            Reporter: stack
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 15199.txt
>
>
> A suggestion that came up out of internal issue (filed by Mr Jan Van Besien) was to move
the scope of the jruby include down so it is only a dependency for the hbase-shell. jruby
jar brings in a bunch of dependencies (joda time for example) which can clash with the includes
of others. Our Sean suggests that could be good to shut down exploit possibilities if jruby
was not globally available. Only downside I can think is that it may no longer be available
to our bin/*rb scripts if we move the jar but perhaps these can be changed so they can find
the ruby jar in new location.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message