hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-13981) Fix ImportTsv spelling and usage issues
Date Wed, 05 Apr 2017 18:18:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-13981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957366#comment-15957366
] 

Hadoop QA commented on HBASE-13981:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s {color} | {color:red}
HBASE-13981 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.3.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12745366/HBASE-13981.4.patch
|
| JIRA Issue | HBASE-13981 |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/6329/console |
| Powered by | Apache Yetus 0.3.0   http://yetus.apache.org |


This message was automatically generated.



> Fix ImportTsv spelling and usage issues
> ---------------------------------------
>
>                 Key: HBASE-13981
>                 URL: https://issues.apache.org/jira/browse/HBASE-13981
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 1.1.0.1
>            Reporter: Lars George
>            Assignee: Gabor Liptak
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.2
>
>         Attachments: HBASE-13981.1.patch, HBASE-13981.2.patch, HBASE-13981.3.patch, HBASE-13981.4.patch
>
>
> The {{ImportTsv}} tool has various spelling and formatting issues. Fix those.
> In code:
> {noformat}
>   public final static String ATTRIBUTE_SEPERATOR_CONF_KEY = "attributes.seperator";
> {noformat}
> It is "separator".
> In usage text:
> {noformat}
> "input data. Another special columnHBASE_TS_KEY designates that this column should be"
> {noformat}
> Space missing.
> {noformat}
> "Record with invalid timestamps (blank, non-numeric) will be treated as bad record."
> {noformat}
> "Records ... as bad records" - plural missing twice.
> {noformat}
> "HBASE_ATTRIBUTES_KEY can be used to specify Operation Attributes per record.
>  Should be specified as key=>value where -1 is used 
>  as the seperator.  Note that more than one OperationAttributes can be specified."
> {noformat}
> - Remove line wraps and indentation. 
> - Fix "separator".
> - Fix wrong separator being output, it is not "-1" (wrong constant use in code)
> - General wording/style could be better (eg. last sentence now uses OperationAttributes
without a space).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message