hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Kulkarni (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-12870) "Major compaction triggered" and "Skipping major compaction" messages lack the region information
Date Thu, 13 Apr 2017 21:32:42 GMT

    [ https://issues.apache.org/jira/browse/HBASE-12870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968246#comment-15968246
] 

Chinmay Kulkarni commented on HBASE-12870:
------------------------------------------

- Manual testing was done by checking that debug logs print the region information. This was
done by modifying the existing UT (TestDefaultCompactSelection.java) and setting a RatioBasedCompaction
policy.

- The FindBugs error is in a code path that is not touched by this patch.

> "Major compaction triggered" and "Skipping major compaction" messages lack the region
information
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12870
>                 URL: https://issues.apache.org/jira/browse/HBASE-12870
>             Project: HBase
>          Issue Type: Improvement
>          Components: Compaction
>    Affects Versions: 1.3.1
>            Reporter: Hari Krishna Dara
>            Assignee: Chinmay Kulkarni
>              Labels: compaction, patch
>             Fix For: 1.3.1
>
>         Attachments: HBASE-12870.patch
>
>
> The below messages coming from {{RatioBasedCompactionPolicy}} log the default {{.toString()}}
output of itself, which is not useful:
> {noformat}
> 2015-01-16 06:15:07,166 DEBUG org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
Major compaction triggered on store org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@4acab1f5;
time since last major compaction 339994249ms
> {noformat}
> {noformat}
> 2015-01-16 09:49:12,872 DEBUG org.apache.hadoop.hbase.regionserver.compactions.RatioBasedCompactionPolicy:
Skipping major compaction of org.apache.hadoop.hbase.regionserver.compactions.ExploringCompactionPolicy@7b9f47bb
because one (major) compacted file only and oldestTime 6795587394ms is < ttl=15552000000
> {noformat}
> It should log the store/region information instead. Unfortunately, this information seems
to be unavailable at this point, so more context needs to be supplied while calling {{RatioBasedCompactionPolicy.isMajorCompaction()}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message