Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9BB88200C3A for ; Fri, 31 Mar 2017 22:28:52 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 9A48A160B80; Fri, 31 Mar 2017 20:28:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E00A7160B7C for ; Fri, 31 Mar 2017 22:28:51 +0200 (CEST) Received: (qmail 95582 invoked by uid 500); 31 Mar 2017 20:28:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95571 invoked by uid 99); 31 Mar 2017 20:28:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Mar 2017 20:28:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AB2D8188A05 for ; Fri, 31 Mar 2017 20:28:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id y886XNxEFbZ8 for ; Fri, 31 Mar 2017 20:28:50 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id AC2455F470 for ; Fri, 31 Mar 2017 20:28:49 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id F1FD9E0048 for ; Fri, 31 Mar 2017 20:28:48 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4B4E821DFE for ; Fri, 31 Mar 2017 20:28:42 +0000 (UTC) Date: Fri, 31 Mar 2017 20:28:42 +0000 (UTC) From: "JC (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HBASE-17862) Condition that always returns true MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 31 Mar 2017 20:28:52 -0000 JC created HBASE-17862: -------------------------- Summary: Condition that always returns true Key: HBASE-17862 URL: https://issues.apache.org/jira/browse/HBASE-17862 Project: HBase Issue Type: Bug Components: Client Reporter: JC Priority: Trivial Hi In recent github mirror of hbase, I've found the following code smell. Path: hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java {code} 209 210 ColumnPaginationFilter other = (ColumnPaginationFilter)o; 211 if (this.columnOffset != null) { 212 return this.getLimit() == this.getLimit() && 213 Bytes.equals(this.getColumnOffset(), other.getColumnOffset()); 214 } {code} It should be? {code} 212 return this.getLimit() == other.getLimit() && {code} This might be just a code smell as Bytes.equals can be enough for the return value but wanted to report just in case. Thanks! -- This message was sent by Atlassian JIRA (v6.3.15#6346)