Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 882C7200C46 for ; Wed, 15 Mar 2017 00:54:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 86AD9160B8C; Tue, 14 Mar 2017 23:54:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D35B6160B7E for ; Wed, 15 Mar 2017 00:54:45 +0100 (CET) Received: (qmail 36696 invoked by uid 500); 14 Mar 2017 23:54:45 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 36682 invoked by uid 99); 14 Mar 2017 23:54:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Mar 2017 23:54:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9F891C05A9 for ; Tue, 14 Mar 2017 23:54:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id cduEAZ90HvAN for ; Tue, 14 Mar 2017 23:54:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 257B95FAF1 for ; Tue, 14 Mar 2017 23:54:43 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 52487E095F for ; Tue, 14 Mar 2017 23:54:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id B134A243B0 for ; Tue, 14 Mar 2017 23:54:41 +0000 (UTC) Date: Tue, 14 Mar 2017 23:54:41 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17779) disable_table_replication returns misleading message and does not turn off replication MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 14 Mar 2017 23:54:46 -0000 [ https://issues.apache.org/jira/browse/HBASE-17779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925282#comment-15925282 ] Hudson commented on HBASE-17779: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2673 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2673/]) HBASE-17779 disable_table_replication returns misleading message and (tedyu: rev 777fea552eab3262e95053b2fc757fc49dfad96d) * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/replication/TestReplicationAdminWithClusters.java > disable_table_replication returns misleading message and does not turn off replication > -------------------------------------------------------------------------------------- > > Key: HBASE-17779 > URL: https://issues.apache.org/jira/browse/HBASE-17779 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Janos Gub > Attachments: HBASE-17779-branch-1.patch, HBASE-17779.patch, HBASE-17779-v2.patch > > > Currently HBaseAdmin#isTableRepEnabled() returns false if ANY of the columns families is not replicated. > Because of this if you have a table where replication is partially enabled, calling disable_table_replication will not have any effect, but will report that replication for a given table is disabled. > Workaround is enabling table replication before disabling. > As a solution quoted from HBASE-17460: > Admin#disableTableReplication() returns nothing and isTableRepEnabled() returns boolean. For master branch, we can let isTableRepEnabled() return enum (partially disabled, disabled, etc) This way, Admin#disableTableReplication() can return meaningful value to the user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)