Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EE4FC200C28 for ; Mon, 13 Mar 2017 11:13:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id ECE99160B85; Mon, 13 Mar 2017 10:13:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 40B65160B60 for ; Mon, 13 Mar 2017 11:13:08 +0100 (CET) Received: (qmail 24017 invoked by uid 500); 13 Mar 2017 10:13:07 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 24006 invoked by uid 99); 13 Mar 2017 10:13:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 10:13:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 045F5C05B0 for ; Mon, 13 Mar 2017 10:13:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id sONwjOXOFIa6 for ; Mon, 13 Mar 2017 10:13:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BE6395F252 for ; Mon, 13 Mar 2017 10:13:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E0E92E04A6 for ; Mon, 13 Mar 2017 10:13:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 75D87243AA for ; Mon, 13 Mar 2017 10:13:04 +0000 (UTC) Date: Mon, 13 Mar 2017 10:13:04 +0000 (UTC) From: "Duo Zhang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17778) Remove the testing code in the AsyncRequestFutureImpl MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Mar 2017 10:13:09 -0000 [ https://issues.apache.org/jira/browse/HBASE-17778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907115#comment-15907115 ] Duo Zhang commented on HBASE-17778: ----------------------------------- Skimmed the patch, overall LGTM. +1 if it could pass all the UTs. > Remove the testing code in the AsyncRequestFutureImpl > ----------------------------------------------------- > > Key: HBASE-17778 > URL: https://issues.apache.org/jira/browse/HBASE-17778 > Project: HBase > Issue Type: Improvement > Affects Versions: 2.0.0 > Reporter: Chia-Ping Tsai > Assignee: Chia-Ping Tsai > Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-17778.v0.patch, HBASE-17778.v1.patch > > > HBASE-16224 left some testing code in the AsyncRequestFutureImpl. It iterates all mutations in order to get the data size. The cost is directly proportional to the size of batch. We should remove it. -- This message was sent by Atlassian JIRA (v6.3.15#6346)