Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 77B88200C2D for ; Sat, 4 Mar 2017 23:16:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 76405160B7F; Sat, 4 Mar 2017 22:16:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C05ED160B61 for ; Sat, 4 Mar 2017 23:16:49 +0100 (CET) Received: (qmail 61498 invoked by uid 500); 4 Mar 2017 22:16:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 61487 invoked by uid 99); 4 Mar 2017 22:16:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Mar 2017 22:16:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 646991A0142 for ; Sat, 4 Mar 2017 22:16:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.547 X-Spam-Level: X-Spam-Status: No, score=-1.547 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 4zGw72wpo9lq for ; Sat, 4 Mar 2017 22:16:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CFF315F470 for ; Sat, 4 Mar 2017 22:16:46 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E90C6E02BE for ; Sat, 4 Mar 2017 22:16:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 433652415A for ; Sat, 4 Mar 2017 22:16:45 +0000 (UTC) Date: Sat, 4 Mar 2017 22:16:45 +0000 (UTC) From: "CHIA-PING TSAI (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (HBASE-17734) guard against possibly coping the qualifier in the ScanDeleteTracker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 04 Mar 2017 22:16:50 -0000 [ https://issues.apache.org/jira/browse/HBASE-17734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] CHIA-PING TSAI reassigned HBASE-17734: -------------------------------------- Assignee: CHIA-PING TSAI > guard against possibly coping the qualifier in the ScanDeleteTracker > -------------------------------------------------------------------- > > Key: HBASE-17734 > URL: https://issues.apache.org/jira/browse/HBASE-17734 > Project: HBase > Issue Type: Improvement > Reporter: CHIA-PING TSAI > Assignee: CHIA-PING TSAI > Priority: Minor > Fix For: 2.0.0 > > Attachments: HBASE-17734.v0.patch > > > If the input cell is ByteBufferKeyValue, the ByteBufferKeyValue#getQualifierArray will copy the qualifier bytes. > ScanDeleteTracker should keep the cell rather than qualifier array. > {noformat} > public void add(Cell cell) { > long timestamp = cell.getTimestamp(); > byte type = cell.getTypeByte(); > if (!hasFamilyStamp || timestamp > familyStamp) { > if (type == KeyValue.Type.DeleteFamily.getCode()) { > hasFamilyStamp = true; > familyStamp = timestamp; > return; > } else if (type == KeyValue.Type.DeleteFamilyVersion.getCode()) { > familyVersionStamps.add(timestamp); > return; > } > if (deleteBuffer != null && type < deleteType) { > // same column, so ignore less specific delete > if (CellUtil.matchingQualifier(cell, deleteBuffer, deleteOffset, deleteLength)) { > return; > } > } > // new column, or more general delete type > deleteBuffer = cell.getQualifierArray(); > deleteOffset = cell.getQualifierOffset(); > deleteLength = cell.getQualifierLength(); > deleteType = type; > deleteTimestamp = timestamp; > } > // missing else is never called. > } > {noformat} -- This message was sent by Atlassian JIRA (v6.3.15#6346)