Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 56351200C36 for ; Fri, 10 Mar 2017 21:53:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 54EA3160B67; Fri, 10 Mar 2017 20:53:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id AA19C160B82 for ; Fri, 10 Mar 2017 21:53:09 +0100 (CET) Received: (qmail 85397 invoked by uid 500); 10 Mar 2017 20:53:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 85383 invoked by uid 99); 10 Mar 2017 20:53:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 20:53:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 4DE9018F152 for ; Fri, 10 Mar 2017 20:53:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 7CSYWK3zHTd8 for ; Fri, 10 Mar 2017 20:53:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 40ECA60DC0 for ; Fri, 10 Mar 2017 20:53:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 43EF9E0A36 for ; Fri, 10 Mar 2017 20:53:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 8E8AD243BC for ; Fri, 10 Mar 2017 20:53:04 +0000 (UTC) Date: Fri, 10 Mar 2017 20:53:04 +0000 (UTC) From: "Sean Busbey (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (HBASE-17725) LimitedPrivate COPROC / PHOENIX interface broken on maintenance release MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 10 Mar 2017 20:53:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-17725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey resolved HBASE-17725. --------------------------------- Resolution: Fixed Hadoop Flags: Incompatible change Release Note: HBASE-16972 introduced a Java Binary Incompatible change for users of the LimitedPrivate(Coprocessor) API; the interface `RpcServiceInterface` added a new method `setRsRpcServices`. Downstream users who implement their own version of the interface will need to implement the method. Summary of responses to the dev@phoenix request is "not a problem" and some instructions on how we could check for this breakage locally. I'm not sure if we want to set up a job to check for problems, but we could do if folks thought it would help long term. > LimitedPrivate COPROC / PHOENIX interface broken on maintenance release > ----------------------------------------------------------------------- > > Key: HBASE-17725 > URL: https://issues.apache.org/jira/browse/HBASE-17725 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 1.2.5, 1.1.8 > Reporter: Sean Busbey > Assignee: Sean Busbey > Priority: Blocker > Fix For: 1.2.5 > > Attachments: 1.2.4_1.2.5RC0_compat_report.html > > > The compatibility report for HBase 1.2.5 RC0 flagged one item, the interface {{RpcServiceInterface}} added a new method {{setRsRpcServices}}. That interface is labeled {{IA.LimitedPrivate(COPROC, PHOENIX)}}. > AFAICT this change came in on HBASE-16972. There's discussion on that ticket about the compatibility impact of the change in logging on earlier releases (which I remain fine with). The only discussion about binary/source compatibility expressly changes a different part of the patch to avoid breaking coprocessors and phoenix. > As an extra wrinkle, this change has already been published in the 1.1.z release line for 1.1.8 and 1.1.9. Apologies, but I haven't gone to verify there wasn't a discussion of this break when 1.1.8 came out. -- This message was sent by Atlassian JIRA (v6.3.15#6346)