Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 6 Mar 2017 19:41:33 +0000 (UTC)
From: "Samarth Jain (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13047504.1488409383000.10270.1488829293085@Atlassian.JIRA>
In-Reply-To: <JIRA.13047504.1488409383000@Atlassian.JIRA>
References: <JIRA.13047504.1488409383000@Atlassian.JIRA> <JIRA.13047504.1488409383775@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17716) Formalize Scan Metric names
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Mar 2017 19:41:38 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897904#comment-15897904 ] 

Samarth Jain commented on HBASE-17716:
--------------------------------------

+1 to the approach you have adopted, [~saint.ack@gmail.com]. This is enough for us - metric names exposed as constants, with the _METRIC_NAME suffix as convention and having them annotated as @Metric to denote that they shouldn't be changed. 


> Formalize Scan Metric names
> ---------------------------
>
>                 Key: HBASE-17716
>                 URL: https://issues.apache.org/jira/browse/HBASE-17716
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Minor
>         Attachments: HBASE-17716.patch
>
>
> HBase provides various metrics through the API's exposed by ScanMetrics class. 
> The JIRA PHOENIX-3248 requires them to be surfaced through the Phoenix Metrics API. Currently these metrics are referred via hard-coded strings, which are not formal and can break the Phoenix API. Hence we need to refactor the code to assign enums for these metrics.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)