Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D5CA2200C38 for ; Wed, 15 Mar 2017 21:49:47 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D47E3160B8A; Wed, 15 Mar 2017 20:49:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 28380160B60 for ; Wed, 15 Mar 2017 21:49:47 +0100 (CET) Received: (qmail 40186 invoked by uid 500); 15 Mar 2017 20:49:46 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 40156 invoked by uid 99); 15 Mar 2017 20:49:45 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Mar 2017 20:49:45 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 516221A06FC for ; Wed, 15 Mar 2017 20:49:45 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ZRTmqO4jDMyg for ; Wed, 15 Mar 2017 20:49:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 531855FE2A for ; Wed, 15 Mar 2017 20:49:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B8BCDE0ADD for ; Wed, 15 Mar 2017 20:49:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id CF8C2243BE for ; Wed, 15 Mar 2017 20:49:41 +0000 (UTC) Date: Wed, 15 Mar 2017 20:49:41 +0000 (UTC) From: "Enis Soztutar (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Mar 2017 20:49:48 -0000 [ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926965#comment-15926965 ] Enis Soztutar commented on HBASE-17584: --------------------------------------- bq. Let's open a thread in the mailing list for this? I think adding method to interface is no harm for most users as they only use the interface, not implement it... We usually allow adding methods to interfaces in minor versions. The idea is that users of interfaces are not affected, but only users extending that interface. There is no distinction in code or tooling about InterfaceAudience.Public being source/binary compatible for using or extending. > Expose ScanMetrics with ResultScanner rather than Scan > ------------------------------------------------------ > > Key: HBASE-17584 > URL: https://issues.apache.org/jira/browse/HBASE-17584 > Project: HBase > Issue Type: Sub-task > Components: Client, mapreduce, scan > Affects Versions: 2.0.0 > Reporter: Duo Zhang > Assignee: Duo Zhang > Fix For: 2.0.0 > > Attachments: HBASE-17584.patch, HBASE-17584-v1.patch > > > I think this have been discussed many times... It is a bad practice to directly modify the Scan object passed in when calling getScanner. The reason that we can not use a copy is we need to use the Scan object to expose scan metrics. So we need to find another way to expose the metrics. -- This message was sent by Atlassian JIRA (v6.3.15#6346)