Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 899AA200C56 for ; Fri, 10 Mar 2017 02:08:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 8801F160B75; Fri, 10 Mar 2017 01:08:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D52FD160B84 for ; Fri, 10 Mar 2017 02:08:44 +0100 (CET) Received: (qmail 47884 invoked by uid 500); 10 Mar 2017 01:08:44 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 47854 invoked by uid 99); 10 Mar 2017 01:08:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Mar 2017 01:08:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 68C661A7A8C for ; Fri, 10 Mar 2017 01:08:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nqpYidOLvpKJ for ; Fri, 10 Mar 2017 01:08:42 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 2917B60DFC for ; Fri, 10 Mar 2017 01:08:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 220AFE095F for ; Fri, 10 Mar 2017 01:08:40 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 69121243D2 for ; Fri, 10 Mar 2017 01:08:38 +0000 (UTC) Date: Fri, 10 Mar 2017 01:08:38 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17453) add Ping into HBase server for deprecated GetProtocolVersion MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 10 Mar 2017 01:08:45 -0000 [ https://issues.apache.org/jira/browse/HBASE-17453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904196#comment-15904196 ] Ted Yu commented on HBASE-17453: -------------------------------- I got the following compilation errors: {code} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project hbase-client: Compilation failure: Compilation failure: [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:[507,55] cannot find symbol [ERROR] symbol: class PingRequest [ERROR] location: class org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:[506,24] cannot find symbol [ERROR] symbol: class PingResponse [ERROR] location: class org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:[505,5] method does not override or implement a method from a supertype [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:[509,19] package PingResponse does not exist [ERROR] /Users/tyu/trunk/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientNoCluster.java:[509,43] cannot find symbol [ERROR] symbol: variable PingResponse [ERROR] location: class org.apache.hadoop.hbase.client.TestClientNoCluster.FakeServer {code} Can you double check ? > add Ping into HBase server for deprecated GetProtocolVersion > ------------------------------------------------------------ > > Key: HBASE-17453 > URL: https://issues.apache.org/jira/browse/HBASE-17453 > Project: HBase > Issue Type: Improvement > Components: regionserver > Affects Versions: 1.2.2 > Reporter: Tianying Chang > Assignee: Tianying Chang > Priority: Minor > Attachments: HBASE-17453-1.2.patch, HBASE-17453-master.patch > > > Our HBase service is hosted in AWS. We saw cases where the connection between the client (Asynchbase in our case) and server stop working but did not throw any exception, therefore traffic stuck. So we added a "Ping" feature in AsyncHBase 1.5 by utilizing the GetProtocolVersion() API provided at RS side, if no traffic for given time, we send the "Ping", if no response back for "Ping", we assume the connect is bad and reconnect. > Now we are upgrading cluster from 94 to 1.2. However, GetProtocolVersion() is deprecated. To be able to support same detect/reconnect feature, we added Ping() in our internal HBase 1.2 branch, and also patched accordingly in Asynchbase 1.7. > We would like to open source this feature since it is useful for use case in AWS environment. -- This message was sent by Atlassian JIRA (v6.3.15#6346)