Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 1 Mar 2017 03:51:45 +0000 (UTC)
From: "Guanghao Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13021710.1479459317000.26086.1488340305553@Atlassian.JIRA>
In-Reply-To: <JIRA.13021710.1479459317000@Atlassian.JIRA>
References: <JIRA.13021710.1479459317000@Atlassian.JIRA> <JIRA.13021710.1479459317444@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17125) Inconsistent result when use
 filter to read data
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 01 Mar 2017 03:51:51 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17125?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D158=
89451#comment-15889451 ]=20

Guanghao Zhang commented on HBASE-17125:
----------------------------------------

I thought this should be fixed by the second idea.
1. check by the max versions of this column, HCD's maxVersions
2. check the kv by filter
3. check the versions which user need, scan.maxVersions

[~huaxiang] [~saint.ack@gmail.com] [~apurtell] [~lhofhansl] [~ram_krish] [~=
Apache9] What do you think about this idea=EF=BC=9F


> Inconsistent result when use filter to read data
> ------------------------------------------------
>
>                 Key: HBASE-17125
>                 URL: https://issues.apache.org/jira/browse/HBASE-17125
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Guanghao Zhang
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: example.diff
>
>
> Assume a cloumn's max versions is 3, then we write 4 versions of this col=
umn. The oldest version doesn't remove immediately. But from the user view,=
 the oldest version has gone. When user use a filter to query, if the filte=
r skip a new version, then the oldest version will be seen again. But after=
 compact the region, then the oldest version will never been seen. So it is=
 weird for user. The query will get inconsistent result before and after re=
gion compaction.
> The reason is matchColumn method of UserScanQueryMatcher. It first check =
the cell by filter, then check the number of versions needed. So if the fil=
ter skip the new version, then the oldest version will be seen again when i=
t is not removed.
> Have a discussion offline with [~Apache9] and [~fenghh], now we have two =
solution for this problem. The first idea is check the number of versions f=
irst, then check the cell by filter. As the comment of setFilter, the filte=
r is called after all tests for ttl, column match, deletes and max versions=
 have been run.
> {code}
>   /**
>    * Apply the specified server-side filter when performing the Query.
>    * Only {@link Filter#filterKeyValue(Cell)} is called AFTER all tests
>    * for ttl, column match, deletes and max versions have been run.
>    * @param filter filter to run on the server
>    * @return this for invocation chaining
>    */
>   public Query setFilter(Filter filter) {
>     this.filter =3D filter;
>     return this;
>   }
> {code}
> But this idea has another problem, if a column's max version is 5 and the=
 user query only need 3 versions. It first check the version's number, then=
 check the cell by filter. So the cells number of the result may less than =
3. But there are 2 versions which don't read anymore.
> So the second idea has three steps.
> 1. check by the max versions of this column
> 2. check the kv by filter
> 3. check the versions which user need.
> But this will lead the ScanQueryMatcher more complicated. And this will b=
reak the javadoc of Query.setFilter.
> Now we don't have a final solution for this problem. Suggestions are welc=
omed.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)