Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 06F55200C28 for ; Mon, 13 Mar 2017 08:19:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 058AE160B60; Mon, 13 Mar 2017 07:19:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4D73C160B85 for ; Mon, 13 Mar 2017 08:19:09 +0100 (CET) Received: (qmail 50790 invoked by uid 500); 13 Mar 2017 07:19:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 50409 invoked by uid 99); 13 Mar 2017 07:19:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Mar 2017 07:19:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 882E0182319 for ; Mon, 13 Mar 2017 07:19:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id l0jzSjH8oPVk for ; Mon, 13 Mar 2017 07:19:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 606575F47E for ; Mon, 13 Mar 2017 07:19:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5ED75E0534 for ; Mon, 13 Mar 2017 07:19:05 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AB31B243AC for ; Mon, 13 Mar 2017 07:19:04 +0000 (UTC) Date: Mon, 13 Mar 2017 07:19:04 +0000 (UTC) From: "ramkrishna.s.vasudevan (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-16438) Create a cell type so that chunk id is embedded in it MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 13 Mar 2017 07:19:10 -0000 [ https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906946#comment-15906946 ] ramkrishna.s.vasudevan commented on HBASE-16438: ------------------------------------------------ Hi All I have updated the patch in RB. There are few things I have added in the RB. To reiterate what is there in RB 1) The ChunkCell is now an extension of BytebufferKV. The problem is that since BBKV already has seqId in it even if we serailize the seqId in the buffer then that ref is of no use. So we may need new Cell impl 2) The chunkId is now added only to the beginning of each chunk and not in every cell. 3) As far as this patch is concerned I feel we can focus on chunkCreation and using this ChunkCell. But adding the seqId inside the buffer and using that buffer has to be done while changing 1) and also integrate it with CellChunkMap flow. 4) This patch also handles clearing the map inside ChunkCreator when there is no chunkPool and we have MSLAB only. > Create a cell type so that chunk id is embedded in it > ----------------------------------------------------- > > Key: HBASE-16438 > URL: https://issues.apache.org/jira/browse/HBASE-16438 > Project: HBase > Issue Type: Sub-task > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: ramkrishna.s.vasudevan > Attachments: MemstoreChunkCell_memstoreChunkCreator_oldversion.patch, MemstoreChunkCell_trunk.patch > > > For CellChunkMap we may need a cell such that the chunk out of which it was created, the id of the chunk be embedded in it so that when doing flattening we can use the chunk id as a meta data. More details will follow once the initial tasks are completed. > Why we need to embed the chunkid in the Cell is described by [~anastas] in this remark over in parent issue https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119 -- This message was sent by Atlassian JIRA (v6.3.15#6346)