Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C3A4A200C32 for ; Thu, 9 Mar 2017 19:47:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C25A6160B75; Thu, 9 Mar 2017 18:47:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 17E23160B5F for ; Thu, 9 Mar 2017 19:47:41 +0100 (CET) Received: (qmail 80165 invoked by uid 500); 9 Mar 2017 18:47:41 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80154 invoked by uid 99); 9 Mar 2017 18:47:41 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Mar 2017 18:47:41 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A4D5BC0F23 for ; Thu, 9 Mar 2017 18:47:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.451 X-Spam-Level: * X-Spam-Status: No, score=1.451 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 0oP-Qa6qJGjL for ; Thu, 9 Mar 2017 18:47:40 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B219260DFC for ; Thu, 9 Mar 2017 18:47:39 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B5DF2E095F for ; Thu, 9 Mar 2017 18:47:38 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1C7C7243B0 for ; Thu, 9 Mar 2017 18:47:38 +0000 (UTC) Date: Thu, 9 Mar 2017 18:47:38 +0000 (UTC) From: "Vincent Poon (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15716) HRegion#RegionScannerImpl scannerReadPoints synchronization constrains random read MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 09 Mar 2017 18:47:42 -0000 [ https://issues.apache.org/jira/browse/HBASE-15716?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D159= 03597#comment-15903597 ]=20 Vincent Poon commented on HBASE-15716: -------------------------------------- I did a quick test with the patch here. Using hbase pe randomRead , I get = 2 - 3% improvement in wall clock time for random reads with 10-20 clients. > HRegion#RegionScannerImpl scannerReadPoints synchronization constrains ra= ndom read > -------------------------------------------------------------------------= --------- > > Key: HBASE-15716 > URL: https://issues.apache.org/jira/browse/HBASE-15716 > Project: HBase > Issue Type: Bug > Components: Performance > Reporter: stack > Assignee: stack > Attachments: 15716.implementation.using.ScannerReadPoints.branch-= 1.patch, 15716.prune.synchronizations.patch, 15716.prune.synchronizations.v= 3.patch, 15716.prune.synchronizations.v4.patch, 15716.prune.synchronization= s.v4.patch, 15716.wip.more_to_be_done.patch, before_after.png, current-bran= ch-1.vs.NoSynchronization.vs.Patch.png, HBASE-15716.branch-1.001.patch, HBA= SE-15716.branch-1.002.patch, HBASE-15716.branch-1.003.patch, HBASE-15716.br= anch-1.004.patch, HBASE-15716.branch-1.005.patch, hits.png, remove_cslm.pat= ch, remove.locks.patch, ScannerReadPoints.java, ScannerReadPoints.v2.java, = Screen Shot 2016-04-26 at 2.05.45 PM.png, Screen Shot 2016-04-26 at 2.06.14= PM.png, Screen Shot 2016-04-26 at 2.07.06 PM.png, Screen Shot 2016-04-26 a= t 2.25.26 PM.png, Screen Shot 2016-04-26 at 6.02.29 PM.png, Screen Shot 201= 6-04-27 at 9.49.35 AM.png, Screen Shot 2016-06-30 at 9.52.52 PM.png, Screen= Shot 2016-06-30 at 9.54.08 PM.png, TestScannerReadPointDoesntGoBack.java, = TestScannerReadPoints.java > > > Here is a [~lhofhansl] special. > When we construct the region scanner, we get our read point and then stor= e it with the scanner instance in a Region scoped CSLM. This is done under = a synchronize on the CSLM. > This synchronize on a region-scoped Map creating region scanners is the o= utstanding point of lock contention according to flight recorder (My work l= oad is workload c, random reads). -- This message was sent by Atlassian JIRA (v6.3.15#6346)