Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 2 Mar 2017 16:23:45 +0000 (UTC)
From: "Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12951497.1458300018000.44250.1488471825552@Atlassian.JIRA>
In-Reply-To: <JIRA.12951497.1458300018000@Atlassian.JIRA>
References: <JIRA.12951497.1458300018000@Atlassian.JIRA> <JIRA.12951497.1458300018373@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-15484) Correct the semantic of batch and
 partial
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Mar 2017 16:24:10 -0000


    [ https://issues.apache.org/jira/browse/HBASE-15484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892535#comment-15892535 ] 

Ted Yu commented on HBASE-15484:
--------------------------------

Patch v5 isn't on review board. Can you upload to review board ?
{code}
+    // return here if allow partials and we will handle batching later.
+    if (scan.getAllowPartialResults()) {
{code}
Previously there was a null check on scan. That is not needed ?
{code}
+    partialResultsRow = result.getRow();
{code}
Typo in variable name.


> Correct the semantic of batch and partial
> -----------------------------------------
>
>                 Key: HBASE-15484
>                 URL: https://issues.apache.org/jira/browse/HBASE-15484
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15484.v05.patch, HBASE-15484-v1.patch, HBASE-15484-v2.patch, HBASE-15484-v3.patch, HBASE-15484-v4.patch
>
>
> Follow-up to HBASE-15325, as discussed, the meaning of setBatch and setAllowPartialResults should not be same. We should not regard setBatch as setAllowPartialResults.
> And isPartial should be define accurately.
> (Considering getBatch==MaxInt if we don't setBatch.) If result.rawcells.length<scan.getBatch && result is not the last part of this row, isPartial==true, otherwise isPartial == false. So if user don't setAllowPartialResults(true), isPartial should always be false.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)