hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-17857) Remove IS annotations from IA.Public classes
Date Fri, 31 Mar 2017 08:37:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950506#comment-15950506
] 

Duo Zhang edited comment on HBASE-17857 at 3/31/17 8:37 AM:
------------------------------------------------------------

And this is the classes which are marked as IA.Public and also IS.Unstable.

{noformat}
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScanResultConsumer.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableRegionLocator.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBase.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/CompactType.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnection.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawScanResultConsumer.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
./hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
./hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AsyncAggregationClient.java
{noformat}

For {{Scan}}, the unstable part is an inner class called ReadType, I think it is OK to remove
the unstable annotation for it.

And for async client related part, I suggest we mark AsyncAdmin related as IA.Private first
and change it to IA.Public when we finish the most works and it is ready for end user.

For {{CompactType}}, I think we should remove the unstable mark as it is used in Admin interface
which is IA.Public and consisdered to be stable.

And for {{HBaseCommonTestingUtility}}, why Unstable? Its sub class {{HBaseTestingUtility}}
is evolving... Let's just remove it.

And for backoff related classess, Let's make it IA.Private first as it is not complete and
seems there is no progress on it.

Thanks.


was (Author: apache9):
And this is the classes which are marked as IA.Public and also IS.Unstable.

{noformat}
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncTable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBuilder.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/Scan.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ExponentialClientBackoffPolicy.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/backoff/ClientBackoffPolicy.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScanResultConsumer.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableRegionLocator.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTableBase.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/CompactType.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnection.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncTable.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawScanResultConsumer.java
./hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncAdmin.java
./hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseCommonTestingUtility.java
./hbase-endpoint/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AsyncAggregationClient.java
{noformat}

For {{Scan}}, the unstable part is an inner class called ReadType, I think it is OK to remove
the unstable annotation for it.

And for async client related part, I suggest we mark AsyncAdmin related as IA.Private first
and change it to IA.Public when we finish the most works and it is ready for end user.

For {{CompactType}}, I think we should remove the unstable mark as it is used in Admin interface
which is IA.Public and consisdered to be stable.

And for {{HBaseCommonTestingUtility}}, why Unstable? It is sub class {{HBaseTestingUtility}}
is evolving... Let's just remove it.

And for backoff related classess, Let's make it IA.Private first as it is not complete and
seems there is no progress on it.

Thanks.

> Remove IS annotations from IA.Public classes
> --------------------------------------------
>
>                 Key: HBASE-17857
>                 URL: https://issues.apache.org/jira/browse/HBASE-17857
>             Project: HBase
>          Issue Type: Sub-task
>          Components: API
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message