hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17728) Create separate build target for Configuration classes
Date Wed, 08 Mar 2017 02:57:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900606#comment-15900606
] 

Ted Yu commented on HBASE-17728:
--------------------------------

In hbase-configuration-loader.h :
{code}
  const std::string kHBaseDefaultXml = "hbase-default.xml";
  const std::string kHBaseSiteXml = "hbase-site.xml";
  const std::string kHBaseDefauktConfPath = "/etc/hbase/conf";
{code}
It seems the declaration of string constants in the code base isn't consistent.

On initial survey, I didn't find the clear advantage of using constexpr. If you can explain
some more, that would be nice.

> Create separate build target for Configuration classes
> ------------------------------------------------------
>
>                 Key: HBASE-17728
>                 URL: https://issues.apache.org/jira/browse/HBASE-17728
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 17728.v1.txt, 17728.v2.txt, 17728.v3.txt, 17728.v4.txt, 17728.v5.txt,
17728.v6.txt, 17728.v7.txt, 17728.v8.txt, 17728.v9.txt
>
>
> User is in security module.
> When User::isSecurityEnabled() is added, we need to query Configuration for security
setting.
> However, this introduces a circular build dependency:
> BUILD FAILED: Cycle found: //connection:connection -> //security:security -> //core:core
-> //connection:connection
> This issue is to create separate build target for Configuration which is depended upon
by both core and security modules.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message