hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17728) Create separate build target for Configuration classes
Date Wed, 08 Mar 2017 01:24:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900526#comment-15900526

Enis Soztutar commented on HBASE-17728:

You should not use {{hbase::optional}} for passing the Configuration. You can declare the
method like this: 

+  static bool isSecurityEnabled(const Configuration &conf) {
+    return KERBEROS.compare(conf.Get("hbase.security.authentication", "")) == 0;
+  }
Please go over EVERY review comment before putting up more patches. There is no use in putting
iterations of half-finished patches addressing only some reviews. This is still not-addressed:

Also the way string constants are declared and named are slightly different. Check client.h
for examples:

> Create separate build target for Configuration classes
> ------------------------------------------------------
>                 Key: HBASE-17728
>                 URL: https://issues.apache.org/jira/browse/HBASE-17728
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 17728.v1.txt, 17728.v2.txt, 17728.v3.txt, 17728.v4.txt, 17728.v5.txt,
17728.v6.txt, 17728.v7.txt, 17728.v8.txt
> User is in security module.
> When User::isSecurityEnabled() is added, we need to query Configuration for security
> However, this introduces a circular build dependency:
> BUILD FAILED: Cycle found: //connection:connection -> //security:security -> //core:core
-> //connection:connection
> This issue is to create separate build target for Configuration which is depended upon
by both core and security modules.

This message was sent by Atlassian JIRA

View raw message