hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17728) Create separate build target for Configuration classes
Date Wed, 08 Mar 2017 19:37:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15901854#comment-15901854

Enis Soztutar commented on HBASE-17728:

bq. It seems the declaration of string constants in the code base isn't consistent.
Indeed. We have started using Google style guides after there was already some code in, and
we did not have the chance to clean up existing usage yet. 
bq. On initial survey, I didn't find the clear advantage of using constexpr. If you can explain
some more, that would be nice.
Fair enough. We are following Google's style guidelines and cpplint scripts in the code base.
For example, naming the constants are like this: https://google.github.io/styleguide/cppguide.html#Constant_Names.
The global static declarations are following this: https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables.

I should have been more explicit about the naming as well in my initial comment. We should
name the static expr as {{kKerberos}}. Please make the change and commit afterwards.  
Also, capitalize {{isSecurityEnabled}} to {{IsSecurityEnabled}}

> Create separate build target for Configuration classes
> ------------------------------------------------------
>                 Key: HBASE-17728
>                 URL: https://issues.apache.org/jira/browse/HBASE-17728
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 17728.v1.txt, 17728.v2.txt, 17728.v3.txt, 17728.v4.txt, 17728.v5.txt,
17728.v6.txt, 17728.v7.txt, 17728.v8.txt, 17728.v9.txt
> User is in security module.
> When User::isSecurityEnabled() is added, we need to query Configuration for security
> However, this introduces a circular build dependency:
> BUILD FAILED: Cycle found: //connection:connection -> //security:security -> //core:core
-> //connection:connection
> This issue is to create separate build target for Configuration which is depended upon
by both core and security modules.

This message was sent by Atlassian JIRA

View raw message