hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17722) Metrics subsystem stop/start messages add a lot of useless bulk to operational logging
Date Fri, 03 Mar 2017 20:07:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894955#comment-15894955
] 

Sean Busbey commented on HBASE-17722:
-------------------------------------

+1

bq. We should ideally vet log output changes while reviewing patches, so as to not even have
to do this afterwards, like now?

This is something I look at when doing reviews. Happy to see an increase in others doing it
as well. Maybe worth a push on HBASE-12396 if other folks are interested?

> Metrics subsystem stop/start messages add a lot of useless bulk to operational logging
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-17722
>                 URL: https://issues.apache.org/jira/browse/HBASE-17722
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 1.3.0, 1.2.4
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Trivial
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17722.patch
>
>
> Metrics subsystem stop/start messages add a lot of useless bulk to operational logging.
Say you are collecting logs from a fleet of thousands of servers and want to have them around
for ~month or longer. It adds up. 
> I think these should at least be at DEBUG level and ideally at TRACE. They don't offer
much utility. Unfortunately they are Hadoop classes so we can tweak log4j.properties defaults
instead. We do this in test resources but not in what we ship in conf/ . 
> {noformat}
> <time> INFO  [<thread>] impl.MetricsSystemImpl: HBase metrics system started
> <time> INFO  [<thread>] impl.MetricsSystemImpl: Stopping HBase metrics system...
> <time> INFO  [<thread>] impl.MetricsSystemImpl: HBase metrics system stopped.
> <time> INFO  [<thread>] impl.MetricsConfig: loaded properties from hadoop-metrics2-hbase.properties
> <time> INFO  [<thread>] impl.MetricsSystemImpl: Scheduled snapshot period
at 10 second(s).
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message