hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17716) Formalize Scan Metric names
Date Mon, 06 Mar 2017 20:13:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15897984#comment-15897984
] 

stack commented on HBASE-17716:
-------------------------------

To be clear, the METRIC annotation won't work. We want metric names to be public. Public annotations
do not take audience qualifications since public means for everyone (makes sense I suppose).

What we can do is make metric names public static finals.  If in a private class, can annotate
the metric name with audience public.

For the few I looked at from your patch, they were from a public class (only checked the first
few).

So, to answer your question, I suggest you make public static final of metric names (with
the _METRIC_NAME suffix) that you need and then we file a follow-up to do the rest.

> Formalize Scan Metric names
> ---------------------------
>
>                 Key: HBASE-17716
>                 URL: https://issues.apache.org/jira/browse/HBASE-17716
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>            Reporter: Karan Mehta
>            Assignee: Karan Mehta
>            Priority: Minor
>         Attachments: HBASE-17716.patch
>
>
> HBase provides various metrics through the API's exposed by ScanMetrics class. 
> The JIRA PHOENIX-3248 requires them to be surfaced through the Phoenix Metrics API. Currently
these metrics are referred via hard-coded strings, which are not formal and can break the
Phoenix API. Hence we need to refactor the code to assign enums for these metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message