hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17595) Add partial result support for small/limited scan
Date Thu, 02 Mar 2017 08:12:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891784#comment-15891784

Phil Yang commented on HBASE-17595:

I find that KeyValueHeap.peak() just returns next Cell in current scanner, doesn't pass to
QueryMatcher or filters. So moreCellsInRow logic in HRegion can not make sure we must have
more. So parital(hasMoreCellsInRow) flag in Result is actually "mayHasMoreCellsInRow". If
it is true, the result may still be the last Result for a row, and if it is false the result
must be the last.
As I said in HBASE-15484, the assumption for hasMoreCellsInRow is not correct. We have to
revert it to mayHasMoreCellsInRow. Should we reopen this issue and revert this commit or open
a new issue? Thanks.

> Add partial result support for small/limited scan
> -------------------------------------------------
>                 Key: HBASE-17595
>                 URL: https://issues.apache.org/jira/browse/HBASE-17595
>             Project: HBase
>          Issue Type: Sub-task
>          Components: asyncclient, Client, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>         Attachments: HBASE-17595-branch-1.patch, HBASE-17595.patch, HBASE-17595-v1.patch
> The partial result support is marked as a 'TODO' when implementing HBASE-17045. And when
implementing HBASE-17508, we found that if we make small scan share the same logic with general
scan, the scan request other than open scanner will not have the small flag so the server
may return  partial result to the client and cause some strange behavior. It is solved by
modifying the logic at server side, but this means the 1.4.x client is not safe to contact
with earlier 1.x server. So we'd better address the problem at client side. Marked as blocker
as this issue should be finished before any 2.x and 1.4.x releases.

This message was sent by Atlassian JIRA

View raw message