hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan
Date Wed, 15 Mar 2017 06:15:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925594#comment-15925594

Duo Zhang commented on HBASE-17584:

Anyway, let's commit this to 2.0 first. If later we decide to also commit it to branch-1,
let's reopen this issue.

[~stack] We explicitly say ' code that implements public APIs will continue to compile' for
patch release but not for minor release, so I assume that for minor release it is allowed...

Let's open a thread in the mailing list for this? I think adding method to interface is no
harm for most users as they only use the interface, not implement it...

And also, the InterfaceStability annotation for public API seems useless? We do not mention
it in our documentation for public API.


> Expose ScanMetrics with ResultScanner rather than Scan
> ------------------------------------------------------
>                 Key: HBASE-17584
>                 URL: https://issues.apache.org/jira/browse/HBASE-17584
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, mapreduce, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>         Attachments: HBASE-17584.patch, HBASE-17584-v1.patch
> I think this have been discussed many times... It is a bad practice to directly modify
the Scan object passed in when calling getScanner. The reason that we can not use a copy is
we need to use the Scan object to expose scan metrics. So we need to find another way to expose
the metrics.

This message was sent by Atlassian JIRA

View raw message