hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17584) Expose ScanMetrics with ResultScanner rather than Scan
Date Tue, 14 Mar 2017 18:42:41 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924769#comment-15924769
] 

Enis Soztutar commented on HBASE-17584:
---------------------------------------

Javadoc says that we are returning null, but if the scanner does not support metrics, we are
throwing an exception. Should we return null instead? 
{code} 
+   * @return the scan metrics, or {@code null} if we do not enable metrics.
{code}
The patch looks good otherwise. 

> Expose ScanMetrics with ResultScanner rather than Scan
> ------------------------------------------------------
>
>                 Key: HBASE-17584
>                 URL: https://issues.apache.org/jira/browse/HBASE-17584
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, mapreduce, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17584.patch, HBASE-17584-v1.patch
>
>
> I think this have been discussed many times... It is a bad practice to directly modify
the Scan object passed in when calling getScanner. The reason that we can not use a copy is
we need to use the Scan object to expose scan metrics. So we need to find another way to expose
the metrics.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message