hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17579) Backport HBASE-16302 to 1.3.1
Date Fri, 03 Mar 2017 01:49:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893559#comment-15893559
] 

Gary Helmling commented on HBASE-17579:
---------------------------------------

I tested this locally again and confirmed that patch v2 does retain the existing "source.ageOfLastShippedOp"
and "sink.ageOfLastAppliedOp" metric names for backwards compatibility.

One comment on the patch: there's a race in CompatibilityRegistry.getGauge().  The method
should return the value from gaugesMap.putIfAbsent() if it is non-null, instead of gauge.
 Otherwise the gauge reference it returns will not be referenced in the map.

Otherwise the patch looks good to me.

> Backport HBASE-16302 to 1.3.1
> -----------------------------
>
>                 Key: HBASE-17579
>                 URL: https://issues.apache.org/jira/browse/HBASE-17579
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>             Fix For: 1.3.1
>
>         Attachments: HBASE-17579.branch-1.3.001.patch, HBASE-17579.branch-1.3.002.patch
>
>
> This is a simple enough change to be included in 1.3.1, and replication monitoring essentially
breaks without this change.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message