hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xiaobing Zhou (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17465) [C++] implement request retry mechanism over RPC
Date Sat, 04 Mar 2017 01:33:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895380#comment-15895380
] 

Xiaobing Zhou commented on HBASE-17465:
---------------------------------------

v11 posted. It addressed all your latest comments except I keep RpcControllerFactory, RpcController
to make easy to follow Java pattern. <template typename RPC_CLIENT> is also kept to
have generic specification, but with default value, e.g.
{code}
<template typename RPC_CLIENT = hbase::RpcClient>
{code}

BTW, I have problems of running make lint, e.g.
{noformat}
bin/cpplint.sh
--2017-03-04 01:29:15--  https://raw.githubusercontent.com/google/styleguide/gh-pages/cpplint/cpplint.py
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... failed: Temporary failure
in name resolution.
wget: unable to resolve host address 'raw.githubusercontent.com'
{noformat}



> [C++] implement request retry mechanism over RPC
> ------------------------------------------------
>
>                 Key: HBASE-17465
>                 URL: https://issues.apache.org/jira/browse/HBASE-17465
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Xiaobing Zhou
>            Assignee: Xiaobing Zhou
>         Attachments: HBASE-17465-HBASE-14850.000.patch, HBASE-17465-HBASE-14850.001.patch,
HBASE-17465-HBASE-14850.002.patch, HBASE-17465-HBASE-14850.003.patch, HBASE-17465-HBASE-14850.004.patch,
HBASE-17465-HBASE-14850.005.patch, HBASE-17465-HBASE-14850.006.patch, HBASE-17465-HBASE-14850.007.patch,
HBASE-17465-HBASE-14850.008.patch, HBASE-17465-HBASE-14850.009.patch, HBASE-17465-HBASE-14850.010.patch,
HBASE-17465-HBASE-14850.011.patch
>
>
> HBASE-17051 implemented RPC layer. Requests retries will make system reliable. This JIRA
proposes adding it, which corresponds to similar implementation in  SingleRequestCallerBuilder
(or BatchCallerBuilder, ScanSingleRegionCallerBuilder, SmallScanCallerBuilder, etc.) and AsyncSingleRequestRpcRetryingCaller.
As a bonus, retry should be more generic, decoupled with HRegionLocation.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message