hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-16584) Backport the new ipc implementation in HBASE-16432 to branch-1
Date Mon, 13 Mar 2017 09:14:04 GMT

    [ https://issues.apache.org/jira/browse/HBASE-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907050#comment-15907050

Yu Li commented on HBASE-16584:

Checking the UT result, it seems to me the only failure is irrelative to changes here:
Failed tests: 
  TestCompactionInDeadRegionServer.test:132 Should fail as our wal file has already been closed,
and walDir has also been renamed

So I guess this is a good base for review? Mind update the patch in RB sir [~Apache9]? Thanks.

> Backport the new ipc implementation in HBASE-16432 to branch-1
> --------------------------------------------------------------
>                 Key: HBASE-16584
>                 URL: https://issues.apache.org/jira/browse/HBASE-16584
>             Project: HBase
>          Issue Type: Task
>          Components: Client, IPC/RPC
>    Affects Versions: 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 1.4.0
>         Attachments: HBASE-16584-branch-1.patch, HBASE-16584-branch-1-v1.patch, HBASE-16584-branch-1-v2.patch,
> Two problems.
> First, as RpcCliemtImpl is the default implementation on branch-1, we need to confirm
that the modification on master does not make it slower. I'm not sure but I used a big lock
to protect everything in the new implementation, so it may have bad impact on performance.
> Second, some configurations of the old AsyncRpcClient is gone. Such as "hbase.rpc.client.threads.max"
and "hbase.rpc.client.nativetransport". Now You could pass a EventLoopGroup object directly
through a helper class which makes it more flexible.

This message was sent by Atlassian JIRA

View raw message