hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-16438) Create a cell type so that chunk id is embedded in it
Date Mon, 20 Mar 2017 07:11:41 GMT

     [ https://issues.apache.org/jira/browse/HBASE-16438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

ramkrishna.s.vasudevan updated HBASE-16438:
    Attachment: HBASE-16438_3_ChunkCreatorwrappingChunkPool.patch

Pls check this latest patch. Sorry for the delay as I am occupied parallely with some other
task. But this patch does what you asked for
-> ChunkCreator is the one created by RegionServer
-> ChunkPool is now an inner class of chunkCreator.
-> ChunkCreator decides on instantiating the pool based on the pool config passed to it.
-> Chunk init also happens inside the ChunkCreator.
-> MSLAB creation of chunk is now single threaded and so there is no CAS operation for
setting curChunk however I felt using curChunk as Atomicreference is still better.

I have not done the JMH profile for this. It is a TODO for me. I should also do some cluster
testing to see if it creates some impact but I feel it should not be a bigger diff in cluster.

I have added test cases to verify these chunks with and without pool and the way the chunk
creation happens with chunk id.

> Create a cell type so that chunk id is embedded in it
> -----------------------------------------------------
>                 Key: HBASE-16438
>                 URL: https://issues.apache.org/jira/browse/HBASE-16438
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-16438_1.patch, HBASE-16438_3_ChunkCreatorwrappingChunkPool.patch,
HBASE-16438.patch, MemstoreChunkCell_memstoreChunkCreator_oldversion.patch, MemstoreChunkCell_trunk.patch
> For CellChunkMap we may need a cell such that the chunk out of which it was created,
the id of the chunk be embedded in it so that when doing flattening we can use the chunk id
as a meta data. More details will follow once the initial tasks are completed. 
> Why we need to embed the chunkid in the Cell is described by [~anastas] in this remark
over in parent issue https://issues.apache.org/jira/browse/HBASE-14921?focusedCommentId=15244119&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244119

This message was sent by Atlassian JIRA

View raw message