hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15431) A bunch of methods are hot and too big to be inlined
Date Thu, 02 Mar 2017 07:05:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891723#comment-15891723
] 

Andrew Purtell commented on HBASE-15431:
----------------------------------------

Inlining increases locality of reference via the instruction cache, but once the cache is
exceeded there are quickly diminishing returns. Hotspot's heuristics are pretty good and I
think are unlikely to be improved upon for the general case. 

> A bunch of methods are hot and too big to be inlined
> ----------------------------------------------------
>
>                 Key: HBASE-15431
>                 URL: https://issues.apache.org/jira/browse/HBASE-15431
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>         Attachments: hotMethods.txt
>
>
> I ran HBase with "-XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions -XX:+PrintInlining"
and then looked for "hot method too big" log lines.
> I'll attach a log of those messages.
> I tried to increase -XX:FreqInlineSize to 1010 to inline all these methods (as long as
they're hot, but actually didn't see any improvement).
> In all cases I primed the JVM to make sure the JVM gets a chance to profile the methods
and decide whether they're hot or not.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message