hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vincent Poon (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15431) A bunch of methods are hot and too big to be inlined
Date Thu, 02 Mar 2017 01:39:53 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15891431#comment-15891431

Vincent Poon commented on HBASE-15431:

For anyone still following this, you can actually force inlining with 

And then in the file put lines like:
inline org.apache.hadoop.hbase.io.hfile.HFileReaderV3$ScannerV3::blockSeek
inline org.apache.hadoop.hbase.regionserver.RSRpcServices::scan

Unfortunately, after forcing inline of all the "hot method too big" methods, I didn't notice
any appreciable performance improvement in benchmarks using PerformanceEvaluation scan/randomRead.
 Perhaps targeting only a few specific methods might be better, but as Andrew pointed out,
it's trial and error.

> A bunch of methods are hot and too big to be inlined
> ----------------------------------------------------
>                 Key: HBASE-15431
>                 URL: https://issues.apache.org/jira/browse/HBASE-15431
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>         Attachments: hotMethods.txt
> I ran HBase with "-XX:+PrintCompilation -XX:+UnlockDiagnosticVMOptions -XX:+PrintInlining"
and then looked for "hot method too big" log lines.
> I'll attach a log of those messages.
> I tried to increase -XX:FreqInlineSize to 1010 to inline all these methods (as long as
they're hot, but actually didn't see any improvement).
> In all cases I primed the JVM to make sure the JVM gets a chance to profile the methods
and decide whether they're hot or not.

This message was sent by Atlassian JIRA

View raw message