Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 27741200C33 for ; Sat, 25 Feb 2017 00:36:52 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 2618C160B69; Fri, 24 Feb 2017 23:36:52 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6EAFE160B79 for ; Sat, 25 Feb 2017 00:36:51 +0100 (CET) Received: (qmail 38064 invoked by uid 500); 24 Feb 2017 23:36:50 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 38053 invoked by uid 99); 24 Feb 2017 23:36:50 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2017 23:36:50 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 31029C0018 for ; Fri, 24 Feb 2017 23:36:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.651 X-Spam-Level: X-Spam-Status: No, score=0.651 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id f1pHS5zFmd9Q for ; Fri, 24 Feb 2017 23:36:49 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6480F5F659 for ; Fri, 24 Feb 2017 23:36:49 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E8714E039F for ; Fri, 24 Feb 2017 23:36:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2B1B924142 for ; Fri, 24 Feb 2017 23:36:44 +0000 (UTC) Date: Fri, 24 Feb 2017 23:36:44 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17690) Clean up MOB code MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 24 Feb 2017 23:36:52 -0000 [ https://issues.apache.org/jira/browse/HBASE-17690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15883756#comment-15883756 ] Ted Yu commented on HBASE-17690: -------------------------------- {code} + long shippedCallSizeLimit = (long) numofFilesToCompact * this.store.getFamily().getBlocksize(); {code} Is the above just an estimate (not all store files have the same size) ? {code} + LOG.error( + "Failed to create del writer, " {code} Since the compaction would continue, the above can be at WARN. > Clean up MOB code > ----------------- > > Key: HBASE-17690 > URL: https://issues.apache.org/jira/browse/HBASE-17690 > Project: HBase > Issue Type: Improvement > Components: mob > Reporter: Jingcheng Du > Assignee: Jingcheng Du > Attachments: HBASE-17690.patch > > > Clean up the code in MOB. > # Fix the incorrect description in comments. > # Fix the warning and remove redundant import in code. > # Remove the references to the deprecated code. > # Add throughput controller for DefaultMobStoreFlusher and DefaultMobStoreCompactor. -- This message was sent by Atlassian JIRA (v6.3.15#6346)