Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 35808200C24 for ; Thu, 23 Feb 2017 08:51:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3418F160B62; Thu, 23 Feb 2017 07:51:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F485160B50 for ; Thu, 23 Feb 2017 08:51:52 +0100 (CET) Received: (qmail 77890 invoked by uid 500); 23 Feb 2017 07:51:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 77879 invoked by uid 99); 23 Feb 2017 07:51:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2017 07:51:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2BCB0C0744 for ; Thu, 23 Feb 2017 07:51:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 4YZT5by2EcOU for ; Thu, 23 Feb 2017 07:51:50 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 4E5445FC0E for ; Thu, 23 Feb 2017 07:51:50 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ED116E086E for ; Thu, 23 Feb 2017 07:51:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 06A4B24132 for ; Thu, 23 Feb 2017 07:51:45 +0000 (UTC) Date: Thu, 23 Feb 2017 07:51:45 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 23 Feb 2017 07:51:53 -0000 [ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880068#comment-15880068 ] Hudson commented on HBASE-17677: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2555 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2555/]) HBASE-17677 ServerName parsing from directory name should be more robust (busbey: rev 040b2f186a08222fc0a0b3bd5c97ccef9cf45368) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractFSWALProvider.java > ServerName parsing from directory name should be more robust to errors from guava's HostAndPort > ----------------------------------------------------------------------------------------------- > > Key: HBASE-17677 > URL: https://issues.apache.org/jira/browse/HBASE-17677 > Project: HBase > Issue Type: Bug > Components: wal > Affects Versions: 2.0.0 > Reporter: Sean Busbey > Assignee: Sean Busbey > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-17677.1.patch > > > our internal Address facade over HostAndPort directly passes on any failures from the underlying Guava implementation. Right now when we parse a ServerName from a WAL directory we properly handle if guava gives us an IllegalArgumentException but we do not handle if it gives us a IllegalStateException. e.g. it uses the former for "I couldn't parse anything out of this string" and the latter for "I parsed a host name but didn't see a port". -- This message was sent by Atlassian JIRA (v6.3.15#6346)