Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 20 Feb 2017 08:15:44 +0000 (UTC)
From: "ramkrishna.s.vasudevan (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13044286.1487496788000.8803.1487578544190@Atlassian.JIRA>
In-Reply-To: <JIRA.13044286.1487496788000@Atlassian.JIRA>
References: <JIRA.13044286.1487496788000@Atlassian.JIRA> <JIRA.13044286.1487496788960@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17662) Disable in-memory flush when
 eplaying from WAL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 20 Feb 2017 08:15:51 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874187#comment-15874187 ] 

ramkrishna.s.vasudevan commented on HBASE-17662:
------------------------------------------------

Small comment
{code}
    for (Store store : stores) {            // update the stores that we are done replaying
889	        ((HStore)store).stopReplayingFromWAL();
890	      }
{code}
Should this be in a try finally block that encloses that 
{code}
if (ServerRegionReplicaUtil.shouldReplayRecoveredEdits(this)) {
{code}
I think rest looks good to me.

> Disable in-memory flush when eplaying from WAL
> ----------------------------------------------
>
>                 Key: HBASE-17662
>                 URL: https://issues.apache.org/jira/browse/HBASE-17662
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Anastasia Braginsky
>         Attachments: HBASE-17662-V02.patch
>
>
> When replaying the edits from WAL, the region's updateLock is not taken, because a single threaded action is assumed. However, the thread-safeness of the in-memory flush of CompactingMemStore is based on taking the region's updateLock. 
> The in-memory flush can be skipped in the replay time (anyway everything is flushed to disk just after the replay). Therefore it is acceptable to just skip the in-memory flush action while the updates come as part of replay from WAL.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)