Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 2A0E0200C35 for ; Sun, 26 Feb 2017 07:12:53 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 288C8160B7B; Sun, 26 Feb 2017 06:12:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 72EA6160B5D for ; Sun, 26 Feb 2017 07:12:52 +0100 (CET) Received: (qmail 33913 invoked by uid 500); 26 Feb 2017 06:12:51 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 33902 invoked by uid 99); 26 Feb 2017 06:12:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 Feb 2017 06:12:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2C9E81A0065 for ; Sun, 26 Feb 2017 06:12:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -2.347 X-Spam-Level: X-Spam-Status: No, score=-2.347 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-2.999, SPF_NEUTRAL=0.652] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id EoCrESd9fa_Z for ; Sun, 26 Feb 2017 06:12:50 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 35EE85FC06 for ; Sun, 26 Feb 2017 06:12:50 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 226F4E05F7 for ; Sun, 26 Feb 2017 06:12:46 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DFA5624134 for ; Sun, 26 Feb 2017 06:12:44 +0000 (UTC) Date: Sun, 26 Feb 2017 06:12:44 +0000 (UTC) From: "Appy (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-17654) RSGroup code refactoring MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 26 Feb 2017 06:12:53 -0000 [ https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-17654: ------------------------- Fix Version/s: 2.0.0 > RSGroup code refactoring > ------------------------ > > Key: HBASE-17654 > URL: https://issues.apache.org/jira/browse/HBASE-17654 > Project: HBase > Issue Type: Improvement > Components: rsgroup > Reporter: Appy > Assignee: Appy > Fix For: 2.0.0 > > Attachments: HBASE-17654.master.001.patch, HBASE-17654.master.002.patch, HBASE-17654.master.003.patch, HBASE-17654.master.004.patch, HBASE-17654.master.005.patch, HBASE-17654.master.006.patch > > > - Making rsGroupInfoManager non-static in RSGroupAdminEndpoint > - Encapsulate RSGroupAdminService into an internal class in RSGroupAdminEndpoint (on need of inheritence). > - Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted empty implementations. > - Change two internal classes in RSGroupAdminServer to non-static (so outer classes' variables can be shared). > - Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in other places). Moved 2 functions to RSGroupManagerImpl because they are only used there. > - Javadoc comments > - Improving variable names > - Maybe other misc refactoring -- This message was sent by Atlassian JIRA (v6.3.15#6346)