Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D1D31200C24 for ; Thu, 23 Feb 2017 12:36:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D0786160B62; Thu, 23 Feb 2017 11:36:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 205D6160B50 for ; Thu, 23 Feb 2017 12:36:49 +0100 (CET) Received: (qmail 88666 invoked by uid 500); 23 Feb 2017 11:36:49 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88655 invoked by uid 99); 23 Feb 2017 11:36:48 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2017 11:36:48 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 65B381A07C0 for ; Thu, 23 Feb 2017 11:36:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id C53hOA8fk3fY for ; Thu, 23 Feb 2017 11:36:47 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id E55865FBBD for ; Thu, 23 Feb 2017 11:36:46 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4F0D1E086E for ; Thu, 23 Feb 2017 11:36:45 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 745EB2414C for ; Thu, 23 Feb 2017 11:36:44 +0000 (UTC) Date: Thu, 23 Feb 2017 11:36:44 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17647) OffheapKeyValue#heapSize() implementation is wrong MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 23 Feb 2017 11:36:51 -0000 [ https://issues.apache.org/jira/browse/HBASE-17647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880290#comment-15880290 ] Hudson commented on HBASE-17647: -------------------------------- FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2556 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2556/]) HBASE-17647 OffheapKeyValue#heapSize() implementation is wrong. (anoopsamjohn: rev ff045cab84ada47ae2d10015649cca8f6edb76ac) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java * (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeSeeker.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/NoLimitScannerContext.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ScannerContext.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyValue.java > OffheapKeyValue#heapSize() implementation is wrong > -------------------------------------------------- > > Key: HBASE-17647 > URL: https://issues.apache.org/jira/browse/HBASE-17647 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Reporter: Anoop Sam John > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17647.patch, HBASE-17647_V2.patch, HBASE-17647_V3.patch > > > We consider the key and data lengths also even though the data is actually in off heap area. We should correct it. > The impact will be at ScannerContext limit tracking where we use heapSize of cells to account the result size. So my proposal is to consider the cells length and heap size in Limit tracking and accounting. We have a maxResultSize which defaults to 2MB. When the sum of all cell's data size reaches 'maxResultSize' OR the sum of all cell's heap size reaches 'maxResultSize' , we need to send back the RPC response -- This message was sent by Atlassian JIRA (v6.3.15#6346)