Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1EECE200C1E for ; Fri, 17 Feb 2017 17:00:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1DB34160B6D; Fri, 17 Feb 2017 16:00:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6D1FD160B55 for ; Fri, 17 Feb 2017 17:00:48 +0100 (CET) Received: (qmail 95072 invoked by uid 500); 17 Feb 2017 16:00:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 95061 invoked by uid 99); 17 Feb 2017 16:00:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 16:00:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 265521858BD for ; Fri, 17 Feb 2017 16:00:47 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id hkrA9KmaDv4N for ; Fri, 17 Feb 2017 16:00:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id A31785FD3B for ; Fri, 17 Feb 2017 16:00:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7469FE0818 for ; Fri, 17 Feb 2017 16:00:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 90CE224130 for ; Fri, 17 Feb 2017 16:00:43 +0000 (UTC) Date: Fri, 17 Feb 2017 16:00:43 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-17644) Always create ByteBufferCells after copying to MSLAB MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Feb 2017 16:00:49 -0000 [ https://issues.apache.org/jira/browse/HBASE-17644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872026#comment-15872026 ] Hudson commented on HBASE-17644: -------------------------------- FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2521 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2521/]) HBASE-17644 Always create ByteBufferCells after copying to MSLAB. (anoopsamjohn: rev 7763dd6688254d37ad611f5d290db47c83cf93d3) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodec.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreChunkPool.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapKeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java * (delete) hbase-common/src/main/java/org/apache/hadoop/hbase/OffheapTag.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferTag.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALCellCodecWithCompression.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/ByteBufferKeyValue.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/protobuf/TestProtobufUtil.java * (delete) hbase-common/src/test/java/org/apache/hadoop/hbase/TestOffheapKeyValue.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java * (add) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/codec/KeyValueCodecWithTags.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStoreLAB.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/SimpleRegionObserver.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALReaderOnSecureWAL.java * (add) hbase-common/src/main/java/org/apache/hadoop/hbase/NoTagsByteBufferKeyValue.java * (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/io/TestTagCompressionContext.java > Always create ByteBufferCells after copying to MSLAB > ---------------------------------------------------- > > Key: HBASE-17644 > URL: https://issues.apache.org/jira/browse/HBASE-17644 > Project: HBase > Issue Type: Sub-task > Components: regionserver > Affects Versions: 2.0.0 > Reporter: ramkrishna.s.vasudevan > Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-17644.patch, HBASE-17644_V2.patch, HBASE-17644_V3.patch > > > We create a cell out of the Bytebuffer that is returned by MSLAB. This BB can be offheap or onheap type. If MSLAB is full we return onheap byte buffer. So the place where we create a cell by copying data to this buffer we either create KeyValue or OffheapKV based on the buffer type. So what we saw in tests is that since we have a combination of Cells the comparisons that happens when adding to memstore happens millions of times and that has an impact on the performance of write path. In read path this is not significant enougth (though we have plans to just create one type of cells every where in Server side). -- This message was sent by Atlassian JIRA (v6.3.15#6346)