Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 7 Feb 2017 04:23:41 +0000 (UTC)
From: "Appy (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13040824.1486432391000.12499.1486441421648@Atlassian.JIRA>
In-Reply-To: <JIRA.13040824.1486432391000@Atlassian.JIRA>
References: <JIRA.13040824.1486432391000@Atlassian.JIRA> <JIRA.13040824.1486432391184@jira-lw-us.apache.org>
Subject: [jira] [Updated] (HBASE-17605) Refactor procedure framework code
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Feb 2017 04:23:46 -0000


     [ https://issues.apache.org/jira/browse/HBASE-17605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Appy updated HBASE-17605:
-------------------------
    Description: 
    - Moved locks out of MasterProcedureScheduler#Queue. One Queue object is used for each namespace/table, which aren't more than 100. So we don't complexity arising from all functionalities being in one place. MasterProcedureLocking#Lock is the new locking class.
    - Removed NamespaceQueue because it wasn't being used as Queue (add,peek,poll,etc functions threw UnsupportedOperationException). It's was only used for locks on namespaces. Now that locks have been moved out of Queue class, it's not needed anymore.
    - Remoed RegionEvent which was there only for locking on regions. Tables/namespaces used locking from Queue class and regions couldn't (there are no separate proc queue at region level), hence the redundance. Now that locking is separate, we can use the same for regions too.
    - Removed QueueInterface class. No declarations, except one implementaion, which makes the point of having an interface moot.
    - Removed QueueImpl, which was the only concrete implementation of abstract Queue class. Moved functions to Queue class itself to avoid unnecessary level in inheritance hierarchy.
    - Removed ProcedureEventQueue class which was just a wrapper around ArrayDeque class.
    - Encapsulated table priority related stuff in a single class.
    - Removed some unused functions.

*Perf using MasterProcedureSchedulerPerformanceEvaluation*
10 threads, 10M ops, 5 tables

Without patch:
10 regions/table : #yield 584980, addBack time 4.1s, poll time 10s
1M regions/table: #yield 16, addBack time 5.9s, poll time 12.9s

With patch:
10 regions/table : #yield 86413, addBack time 4.1s, poll time 8.2s
1M regions/table: #yield 9, addBack time 6s, poll time 13s


  was:
    - Moved locks out of MasterProcedureScheduler#Queue. One Queue object is used for each namespace/table, which aren't more than 100. So we don't complexity arising from all functionalities being in one place. MasterProcedureLocking#Lock is the new locking class.
    - Removed NamespaceQueue because it wasn't being used as Queue (add,peek,poll,etc functions threw UnsupportedOperationException). It's was only used for locks on namespaces. Now that locks have been moved out of Queue class, it's not needed anymore.
    - Remoed RegionEvent which was there only for locking on regions. Tables/namespaces used locking from Queue class and regions couldn't (there are no separate proc queue at region level), hence the redundance. Now that locking is separate, we can use the same for regions too.
    - Removed QueueInterface class. No declarations, except one implementaion, which makes the point of having an interface moot.
    - Removed QueueImpl, which was the only concrete implementation of abstract Queue class. Moved functions to Queue class itself to avoid unnecessary level in inheritance hierarchy.
    - Removed ProcedureEventQueue class which was just a wrapper around ArrayDeque class.
    - Encapsulated table priority related stuff in a single class.
    - Removed some unused functions.


> Refactor procedure framework code
> ---------------------------------
>
>                 Key: HBASE-17605
>                 URL: https://issues.apache.org/jira/browse/HBASE-17605
>             Project: HBase
>          Issue Type: Improvement
>          Components: proc-v2
>            Reporter: Appy
>            Assignee: Appy
>         Attachments: HBASE-17605.master.001.patch
>
>
>     - Moved locks out of MasterProcedureScheduler#Queue. One Queue object is used for each namespace/table, which aren't more than 100. So we don't complexity arising from all functionalities being in one place. MasterProcedureLocking#Lock is the new locking class.
>     - Removed NamespaceQueue because it wasn't being used as Queue (add,peek,poll,etc functions threw UnsupportedOperationException). It's was only used for locks on namespaces. Now that locks have been moved out of Queue class, it's not needed anymore.
>     - Remoed RegionEvent which was there only for locking on regions. Tables/namespaces used locking from Queue class and regions couldn't (there are no separate proc queue at region level), hence the redundance. Now that locking is separate, we can use the same for regions too.
>     - Removed QueueInterface class. No declarations, except one implementaion, which makes the point of having an interface moot.
>     - Removed QueueImpl, which was the only concrete implementation of abstract Queue class. Moved functions to Queue class itself to avoid unnecessary level in inheritance hierarchy.
>     - Removed ProcedureEventQueue class which was just a wrapper around ArrayDeque class.
>     - Encapsulated table priority related stuff in a single class.
>     - Removed some unused functions.
> *Perf using MasterProcedureSchedulerPerformanceEvaluation*
> 10 threads, 10M ops, 5 tables
> Without patch:
> 10 regions/table : #yield 584980, addBack time 4.1s, poll time 10s
> 1M regions/table: #yield 16, addBack time 5.9s, poll time 12.9s
> With patch:
> 10 regions/table : #yield 86413, addBack time 4.1s, poll time 8.2s
> 1M regions/table: #yield 9, addBack time 6s, poll time 13s


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)