Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 6 Feb 2017 09:12:41 +0000 (UTC)
From: "Phil Yang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13040523.1486351324000.3803.1486372361868@Atlassian.JIRA>
In-Reply-To: <JIRA.13040523.1486351324000@Atlassian.JIRA>
References: <JIRA.13040523.1486351324000@Atlassian.JIRA> <JIRA.13040523.1486351324752@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17599) Also set the partial flag of
 Result to true if we reach the batch limit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Feb 2017 09:12:46 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853727#comment-15853727 ] 

Phil Yang commented on HBASE-17599:
-----------------------------------

Do we want to set flag in proto of response only, or expose to users' Result.isPartial()?
HBASE-15484 wants to change the semantic users' Result.isPartial(), without that patch, they are same. But it will reorg cells if user setBatch but don't allow partial, so the returned Result may be not same as responded from server.
I think users need be able to know if the Result is exactly the last Result of this row or not, but now when users setBatch(5) and Result.size()==5, they can not know if it is the last one or this row. So we may change the meaning of isPartial or create a new api?

> Also set the partial flag of Result to true if we reach the batch limit
> -----------------------------------------------------------------------
>
>                 Key: HBASE-17599
>                 URL: https://issues.apache.org/jira/browse/HBASE-17599
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17599.patch
>
>
> For now if we set scan.allowPartial(true), the partial result returned will have the partial flag set to true. But for scan.setBatch(xx), the partial result returned will not be marked as partial.
> This is an Incompatible change, indeed. But I do not think it will introduce any issues as we just provide more informations to client. The old partial flag for batched scan is always false so I do not think anyone can make use of it.
> This is very important for the limited scan to support partial results from server. If we get a Result which partial flag is false then we know we get the whole row. Otherwise we need to fetch one more row to see if the row key is changed which causes the logic to be more complicated.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)