Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 6 Feb 2017 09:08:41 +0000 (UTC)
From: "Duo Zhang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13040523.1486351324000.3747.1486372121713@Atlassian.JIRA>
In-Reply-To: <JIRA.13040523.1486351324000@Atlassian.JIRA>
References: <JIRA.13040523.1486351324000@Atlassian.JIRA> <JIRA.13040523.1486351324752@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17599) Also set the partial flag of
 Result to true if we reach the batch limit
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Feb 2017 09:08:53 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853719#comment-15853719 ] 

Duo Zhang commented on HBASE-17599:
-----------------------------------

So here we need two 'partial' flags? One is to indicate that this row is a partial row, another is to indicate that the returned Result has not reached the batch limit yet?

{quote}
  /**
   * Whether or not the result is a partial result. Partial results contain a subset of the cells
   * for a row and should be combined with a result representing the remaining cells in that row to
   * form a complete (non-partial) result.
   * @return Whether or not the result is a partial result
   */
  public boolean isPartial() {
    return partial;
  }
{quote}

This is the comment of isPartial, I do not see any batch related explainations? And for example, we have a row with 100 cells. If we set batch to 10, and we return 3 cells at the first time, it will be marked as partial. And the second we return 10 cells, it will not be marked as partial? I do not think this is useful...

Thanks.

> Also set the partial flag of Result to true if we reach the batch limit
> -----------------------------------------------------------------------
>
>                 Key: HBASE-17599
>                 URL: https://issues.apache.org/jira/browse/HBASE-17599
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Client, scan
>    Affects Versions: 2.0.0, 1.4.0
>            Reporter: Duo Zhang
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-17599.patch
>
>
> For now if we set scan.allowPartial(true), the partial result returned will have the partial flag set to true. But for scan.setBatch(xx), the partial result returned will not be marked as partial.
> This is an Incompatible change, indeed. But I do not think it will introduce any issues as we just provide more informations to client. The old partial flag for batched scan is always false so I do not think anyone can make use of it.
> This is very important for the limited scan to support partial results from server. If we get a Result which partial flag is false then we know we get the whole row. Otherwise we need to fetch one more row to see if the row key is changed which causes the logic to be more complicated.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)