Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Mon, 6 Feb 2017 21:27:42 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.13026863.1481254151000.9534.1486416462001@Atlassian.JIRA>
In-Reply-To: <JIRA.13026863.1481254151000@Atlassian.JIRA>
References: <JIRA.13026863.1481254151000@Atlassian.JIRA> <JIRA.13026863.1481254151582@jira-lw-us.apache.org>
Subject: [jira] [Commented] (HBASE-17281) FN should use datanode port from
 hdfs configuration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 06 Feb 2017 21:27:47 -0000


    [ https://issues.apache.org/jira/browse/HBASE-17281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15854773#comment-15854773 ] 

stack commented on HBASE-17281:
-------------------------------

[~thiruvel] Done. I also made you an administrator so you can do it yourself going forward. Thanks [~thiruvel]


> FN should use datanode port from hdfs configuration
> ---------------------------------------------------
>
>                 Key: HBASE-17281
>                 URL: https://issues.apache.org/jira/browse/HBASE-17281
>             Project: HBase
>          Issue Type: Sub-task
>          Components: FavoredNodes
>            Reporter: Thiruvel Thirumoolan
>            Assignee: Thiruvel Thirumoolan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17281.master.001.patch, HBASE-17281.master.002.patch, HBASE-17281.master.003.patch, HBASE-17281.master.004.patch, HBASE-17281.master.005.patch
>
>
> Currently we use the ServerName port for providing favored node hints. We should use the DN port from hdfs-site.xml instead to avoid warning messages in region server logs. The warnings will be from this section of HDFS code, it moves across classes.
> https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DataStreamer.java#L1758
> {code}
>   private boolean[] getPinnings(DatanodeInfo[] nodes) {
>     if (favoredNodes == null) {
>       return null;
>     } else {
>       boolean[] pinnings = new boolean[nodes.length];
>       HashSet<String> favoredSet = new HashSet<>(Arrays.asList(favoredNodes));
>       for (int i = 0; i < nodes.length; i++) {
>         pinnings[i] = favoredSet.remove(nodes[i].getXferAddrWithHostname());
>         LOG.debug("{} was chosen by name node (favored={}).",
>             nodes[i].getXferAddrWithHostname(), pinnings[i]);
>       }
>       if (!favoredSet.isEmpty()) {
>         // There is one or more favored nodes that were not allocated.
>         LOG.warn("These favored nodes were specified but not chosen: "
>             + favoredSet + " Specified favored nodes: "
>             + Arrays.toString(favoredNodes));
>       }
>       return pinnings;
>     }
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)