Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B1B50200C22 for ; Tue, 21 Feb 2017 19:58:48 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id AF8BE160B74; Tue, 21 Feb 2017 18:58:48 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 04178160B4F for ; Tue, 21 Feb 2017 19:58:47 +0100 (CET) Received: (qmail 31330 invoked by uid 500); 21 Feb 2017 18:58:47 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 31317 invoked by uid 99); 21 Feb 2017 18:58:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 21 Feb 2017 18:58:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B08EE1A02B3 for ; Tue, 21 Feb 2017 18:58:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.999 X-Spam-Level: X-Spam-Status: No, score=-1.999 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id PIjzpfkl7tEy for ; Tue, 21 Feb 2017 18:58:46 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5D43A5FACA for ; Tue, 21 Feb 2017 18:58:45 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 832B3E09A3 for ; Tue, 21 Feb 2017 18:58:44 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2F13E24123 for ; Tue, 21 Feb 2017 18:58:44 +0000 (UTC) Date: Tue, 21 Feb 2017 18:58:44 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15328) Unvalidated Redirect in HMaster MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 21 Feb 2017 18:58:48 -0000 [ https://issues.apache.org/jira/browse/HBASE-15328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876483#comment-15876483 ] Hudson commented on HBASE-15328: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #834 (See [https://builds.apache.org/job/HBase-1.3-IT/834/]) HBASE-15328 sanity check the redirect used to send master info requests (busbey: rev fdb7655c6826cc2bcb5003b4d15385fee1388343) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestInfoServers.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java > Unvalidated Redirect in HMaster > ------------------------------- > > Key: HBASE-15328 > URL: https://issues.apache.org/jira/browse/HBASE-15328 > Project: HBase > Issue Type: Bug > Components: security > Reporter: stack > Assignee: Sean Busbey > Priority: Minor > Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10 > > Attachments: HBASE-15328.0.patch, HBASE-15328.1.patch > > > See OWASP page on why we should clean it up someday: > https://www.owasp.org/index.php/Unvalidated_Redirects_and_Forwards_Cheat_Sheet > Here is where we do the redirect: > {code} > @Override > public void doGet(HttpServletRequest request, > HttpServletResponse response) throws ServletException, IOException { > String redirectUrl = request.getScheme() + "://" > + request.getServerName() + ":" + regionServerInfoPort > + request.getRequestURI(); > response.sendRedirect(redirectUrl); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)