hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17699) Fix TestLockProcedure
Date Sat, 25 Feb 2017 23:44:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884440#comment-15884440

Appy commented on HBASE-17699:

bq. In the MasterProcedureScheduler#clear, should you call the super#clear? Fix on commit.
There is no super#clear. There's no implementation of that function in AbstractProcedureScheduler.

Updated javadoc for ProcedureScheduler#clear() to mention it's real purpose. That'll clear
the confusion around comment.

bq. Should we clear table and server queue and runqueues in the MasterProcedureScheduler when
#clear is called?
It already does by calling clearQueue() which cleans up runqueues, tableMap and serverBuckets.

bq. The clearQueue() is useless for AbstractProcedureScheduler. Should it be removed?
Good point. Removed.

> Fix TestLockProcedure
> ---------------------
>                 Key: HBASE-17699
>                 URL: https://issues.apache.org/jira/browse/HBASE-17699
>             Project: HBase
>          Issue Type: Bug
>          Components: proc-v2
>            Reporter: Appy
>            Assignee: Appy
>            Priority: Blocker
>         Attachments: HBASE-17699.master.001.patch
> TestLockProcedure is failing consistently after HBASE-17605. It's interesting that HadoopQA
didn't report any test failures on that jira. Anyways, need to fix the test now.

This message was sent by Atlassian JIRA

View raw message