hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17677) ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
Date Thu, 23 Feb 2017 06:12:44 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879945#comment-15879945
] 

Hudson commented on HBASE-17677:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-1.2-JDK7 #106 (See [https://builds.apache.org/job/HBase-1.2-JDK7/106/])
HBASE-17677 Just the new tests from 'ServerName parsing from directory (busbey: rev 7314575a2e734abedcf9445b1c02e6533fbc8a05)
* (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALMethods.java


> ServerName parsing from directory name should be more robust to errors from guava's HostAndPort
> -----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-17677
>                 URL: https://issues.apache.org/jira/browse/HBASE-17677
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 2.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 2.0.0, 1.4.0, 1.3.1, 1.2.5, 1.1.10
>
>         Attachments: HBASE-17677.1.patch
>
>
> our internal Address facade over HostAndPort directly passes on any failures from the
underlying Guava implementation. Right now when we parse a ServerName from a WAL directory
we properly handle if guava gives us an IllegalArgumentException but we do not handle if it
gives us a IllegalStateException. e.g. it uses the former for "I couldn't parse anything out
of this string" and the latter for "I parsed a host name but didn't see a port".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message