hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17654) RSGroup code refactoring
Date Mon, 27 Feb 2017 19:53:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886410#comment-15886410
] 

Hudson commented on HBASE-17654:
--------------------------------

SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2582 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2582/])
HBASE-17654 Add support for table.existsAll in thrift2 THBaseservice (tedyu: rev e8f9de7851ca91bc840618e6ca16493b1060f6dc)
* (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftHBaseServiceHandler.java
* (edit) hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
* (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/generated/THBaseService.java
* (edit) hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandler.java


> RSGroup code refactoring
> ------------------------
>
>                 Key: HBASE-17654
>                 URL: https://issues.apache.org/jira/browse/HBASE-17654
>             Project: HBase
>          Issue Type: Improvement
>          Components: rsgroup
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17654.master.001.patch, HBASE-17654.master.002.patch, HBASE-17654.master.003.patch,
HBASE-17654.master.004.patch, HBASE-17654.master.005.patch, HBASE-17654.master.006.patch
>
>
> - Making rsGroupInfoManager non-static in RSGroupAdminEndpoint
> - Encapsulate RSGroupAdminService into an internal class in RSGroupAdminEndpoint (on
need of inheritence).
> - Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted empty implementations.
> - Change two internal classes in RSGroupAdminServer to non-static (so outer classes'
variables can be shared).
> - Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in other places).
Moved 2 functions to RSGroupManagerImpl because they are only used there.
> - Javadoc comments
> - Improving variable names
> - Maybe other misc refactoring



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message