hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Appy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-17654) RSGroup code refactoring
Date Mon, 27 Feb 2017 22:33:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-17654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15886669#comment-15886669
] 

Appy commented on HBASE-17654:
------------------------------

Ignore the last two Hudson messages, it's because HBASE-17689 was committed with wrong jira
number in description.

> RSGroup code refactoring
> ------------------------
>
>                 Key: HBASE-17654
>                 URL: https://issues.apache.org/jira/browse/HBASE-17654
>             Project: HBase
>          Issue Type: Improvement
>          Components: rsgroup
>            Reporter: Appy
>            Assignee: Appy
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17654.master.001.patch, HBASE-17654.master.002.patch, HBASE-17654.master.003.patch,
HBASE-17654.master.004.patch, HBASE-17654.master.005.patch, HBASE-17654.master.006.patch
>
>
> - Making rsGroupInfoManager non-static in RSGroupAdminEndpoint
> - Encapsulate RSGroupAdminService into an internal class in RSGroupAdminEndpoint (on
need of inheritence).
> - Make RSGroupAdminEndpoint extend BaseMasterObserver, so got rid of unwanted empty implementations.
> - Change two internal classes in RSGroupAdminServer to non-static (so outer classes'
variables can be shared).
> - Rename RSGroupSerDe to RSGroupProtobufUtil('ProtobufUtil' is what we use in other places).
Moved 2 functions to RSGroupManagerImpl because they are only used there.
> - Javadoc comments
> - Improving variable names
> - Maybe other misc refactoring



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message